chore: move to gh actions #85
Conversation
frezbo
force-pushed
the
chore/move-to-gh-actions
branch
5 times, most recently
from
c00ce80 to
2ac79c3
Compare
frezbo
force-pushed
the
chore/move-to-gh-actions
branch
3 times, most recently
from
d1aa699 to
954cd2a
Compare
frezbo
force-pushed
the
chore/move-to-gh-actions
branch
7 times, most recently
from
ed96922 to
4b59b4b
Compare
.github/workflows/ci.yaml
Outdated
| branches: | ||
| - main | ||
| - release-* | ||
| schedule: |
There was a problem hiding this comment.
I mean not sure which step runs there
There was a problem hiding this comment.
schedule is cron, runs weekly the reproducibilty, there are if condition to match things
There was a problem hiding this comment.
I see that reproducibility depends on label, not on schedule event?
.github/workflows/ci.yaml
Outdated
| env: | ||
| CI_ARGS: --cache-from=type=registry,ref=registry.dev.siderolabs.io/${GITHUB_REPOSITORY}:buildcache --cache-to=type=registry,ref=registry.dev.siderolabs.io/${GITHUB_REPOSITORY}:buildcache,mode=max | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, labeled] |
There was a problem hiding this comment.
does it mean it will run the build each time labeled is touched?
There was a problem hiding this comment.
only if label is removed and added
There was a problem hiding this comment.
yes, but technically on any label change? it will re-run all steps?
There was a problem hiding this comment.
yeh, kind of, but the step will be skipped if label is not matched
There was a problem hiding this comment.
but the build will still run though... I wonder if it should be a separate workflow?
There was a problem hiding this comment.
yeh, even if separate workflow, it starts a job anyways, so not much different. Well i could have a different one that just triggers on label and skip at job level. I guess it's probably easier to read
.github/workflows/ci.yaml
Outdated
| if: github.event_name != 'schedule' | ||
| run: | | ||
| make | ||
| - name: reproducibility |
There was a problem hiding this comment.
does it mean it runs after build?
There was a problem hiding this comment.
no, only on schedule or when there's the label
There was a problem hiding this comment.
yep, but should it be a separate workflow? would it be cleaner?
this will have its own status, as reproducibility is independent of all other steps
There was a problem hiding this comment.
yeh,i initially had that, felt like a lot of duplication, so moved it along the same job
frezbo
force-pushed
the
chore/move-to-gh-actions
branch
9 times, most recently
from
6de4ea8 to
d54ac0d
Compare
Move to GitHub actions. Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
chore/move-to-gh-actions
branch
from
d54ac0d to
639ddad
Compare
|
/m |
Move to GitHub actions.